Tweak example in configuration combinations #5825
Merged
+3
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaps the platform for one project configuration in the Configuration X Platform matrix example, so it's clearer why the first set requires the existence of the second set. Otherwise, it's not obvious why three Win32 configurations require three x64 configurations (but not three ARM configurations).
|
@dmringo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit e1cc89b: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
Updated per conversation with dev owner.
TylerMSFT
approved these changes
Oct 9, 2025
|
Thank you, @dmringo. |
prmerger-automator
bot
added
ready-to-merge
do-not-merge
and removed
do-not-merge
ready-to-merge
labels
|
Learn Build status updates of commit 6f66c4f: ✅ Validation status: passed
For more details, please refer to the build report. |
|
#sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps the platform for one project configuration in the Configuration X Platform matrix example, so it's clearer why the first set requires the existence of the second set. Otherwise, it's not obvious why three Win32 configurations require three x64 configurations (but not three ARM configurations).
I don't actually know the IDE internals, so I'm not sure if there's an implicit expectation of the
x64platform (or maybe just the native host arch) that would make my suggested change irrelevant. As written though, the existing wording makes it sound like you'd need thex64platform represented in at least one of the antecedent configurations.